Skip to content

Conversation

kpavlov
Copy link
Contributor

@kpavlov kpavlov commented Oct 12, 2025

Add StreamableHttpClientTest with test infrastructure setup and dependencies

Motivation and Context

To test Streaming HTTP Transport

How Has This Been Tested?

Integration test added

Breaking Changes

No, only tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@kpavlov kpavlov requested a review from devcrocod October 12, 2025 22:51
@kpavlov kpavlov force-pushed the kpavlov/streamable-client-transport-test branch from 3bb4c72 to 4226096 Compare October 15, 2025 12:20
@kpavlov kpavlov requested a review from tiginamaria October 15, 2025 16:01
@kpavlov kpavlov force-pushed the kpavlov/streamable-client-transport-test branch 2 times, most recently from 8373929 to 8cc6f64 Compare October 15, 2025 16:11
@kpavlov kpavlov marked this pull request as ready for review October 15, 2025 16:23
@kpavlov kpavlov added enhancement New feature or request tests labels Oct 15, 2025
junitXml.includeSystemOutLog.set(true)
junitXml.includeSystemErrLog.set(true)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for visibility

forkEvery = 100
testLogging {
exceptionFormat = TestExceptionFormat.SHORT
showStandardStreams = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for visibility

e5l
e5l previously approved these changes Oct 15, 2025
Copy link
Contributor

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice library

@kpavlov kpavlov force-pushed the kpavlov/streamable-client-transport-test branch from 8cc6f64 to a75f379 Compare October 15, 2025 17:00
@kpavlov kpavlov requested a review from e5l October 15, 2025 17:13
@kpavlov
Copy link
Contributor Author

kpavlov commented Oct 15, 2025

I extracted MockMcp abstraction, need another +1

- Add Netty convention plugin
- Update Kotlin compiler and junit platform settings
- Mock DELETE /mcp in StreamableHttpClientTest; Refactor Mokksy calls
@kpavlov kpavlov force-pushed the kpavlov/streamable-client-transport-test branch from a75f379 to d82fc22 Compare October 15, 2025 17:30
Copy link

@aozherelyeva aozherelyeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@kpavlov kpavlov merged commit d60e8b6 into main Oct 17, 2025
4 checks passed
@kpavlov kpavlov deleted the kpavlov/streamable-client-transport-test branch October 17, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants