fix: make react a peer dependency to support multiple versions #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move react and react-dom from dependencies to peerDependencies with support for React 17, 18, and 19. This allows consumers to use their preferred React version instead of forcing v19. - Added peerDependencies for react/react-dom (^17 || ^18 || ^19) - Marked react dependencies as optional in peerDependenciesMeta - Moved react/react-dom to devDependencies for local development - React is already externalized in the build (build.bun.ts) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
commit: |
jonathanhefner
approved these changes
Dec 16, 2025
Member
jonathanhefner
left a comment
jonathanhefner
left a comment
There was a problem hiding this comment.
Looks good. Note that all examples will still require React 19, but that should be fine.
This was referenced Dec 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
reactandreact-domfromdependenciestopeerDependencieswith support for React 17, 18, and 19peerDependenciesMeta(only/reactsubpath needs them)reactandreact-domindevDependenciesfor local development/testingFixes #163
Test plan
npm installsucceedsnpm testpasses (33 tests)npm run build:allsucceeds (all examples build)🤖 Generated with Claude Code