refactor: rename request methods to remove send prefix #161
+59
−259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Following the MCP TS SDK convention where request methods don't have the "send" prefix (reserved for notifications): - App.sendMessage() → App.message() - App.sendOpenLink() → App.openLink() - AppBridge.sendResourceTeardown() → AppBridge.resourceTeardown() The old method names are kept as deprecated aliases for backwards compatibility. Updated all examples to use the new method names. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ochafik
force-pushed
the
ochafik/rename-request-methods
branch
from
3292924 to
a11a022
Compare
- Update existing tests to use new method names (message, openLink) - Add tests verifying deprecated aliases are same reference as new methods - Add tests verifying deprecated aliases still work functionally 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ochafik
requested review from
antonpk1 and
jonathanhefner
and removed request for
jonathanhefner
jonathanhefner
previously approved these changes
Dec 16, 2025
Member
There was a problem hiding this comment.
My thought is that this convention only works when the method name already contains a verb. For example, openLink() works, but resourceTeardown() doesn't quite work — it would need to be teardownResource(). And message() is very borderline.
But I will defer to you.
- App.message() → App.sendMessage() (with deprecated message alias) - AppBridge.resourceTeardown() → AppBridge.teardownResource() (with deprecated aliases) This better follows the pattern where methods that send data have 'send' or action verb prefix.
Collaborator
Author
|
Thanks @jonathanhefner! As discussed offline:
|
The app.message alias was removed since sendMessage is the correct name. sendResourceTeardown already exists in AppBridge.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following the MCP TS SDK convention where request methods don't have the "send" prefix (reserved for notifications):
App.sendOpenLink()→App.openLink()AppBridge.sendResourceTeardown()→AppBridge.teardownResource()The old method names are kept as deprecated aliases for backwards compatibility.
Changes
AppandAppBridgeclasses@deprecatedaliases for old method namesBackwards Compatibility
✅ Non-breaking change - deprecated aliases ensure existing code continues to work.
🤖 Generated with Claude Code