Add integration-server and simplify basic-server-{react,vanillajs}
#157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dedicated `integration-server` example (duplicated from `basic-server-react`) to preserve E2E testing capabilities while allowing `basic-server-react` to be simplified as a minimal example. Changes: - Add `examples/integration-server` exercising SDK communication APIs - Update E2E tests to use `integration-server` instead of `basic-server-react` and `basic-server-vanillajs` - Use server name labels instead of indices for more robust test selection - Remove `basic-react.png` and `basic-vanillajs.png` golden snapshots 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
commit: |
Add `id="server-time"` to the integration server's time display element and update the E2E test mask selector to use `#server-time` instead of the generic `code` element selector. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Remove dependency on shared `server-utils.js` - Use Express + `StreamableHTTPServerTransport` directly - Simplify tool response to plain ISO time string - Add graceful shutdown handling - Remove artificial delay in UI teardown handler 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Remove dependency on shared `server-utils.js` - Use Express + `StreamableHTTPServerTransport` directly - Simplify tool response to plain ISO time string - Add graceful shutdown handling - Remove artificial delay in UI teardown handler 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
jonathanhefner
force-pushed
the
add-example-server-for-integration-testing
branch
from
3ba8a51 to
4cc89e2
Compare
Member
Author
|
Closing in favor or #182. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
examples/integration-server, which is a clone of the current version ofbasic-server-react, including all necessary code for E2E tests. Furthermore, this PR simplifiesbasic-server-reactandbasic-server-vanillajsso that they become minimal, standalone examples (using a single transport, without depending on../shared/server-utils.js).