Skip to content

Conversation

mikekistler
Copy link
Contributor

This PR adds the docs samples into the solution so they will be built as part of CI, which should flag when PRs cause the samples to break.

@mikekistler mikekistler marked this pull request as draft September 2, 2025 19:45
@mikekistler
Copy link
Contributor Author

@eiriktsarpalis Is there a build step in in our PR checks? I just assumed there was but looking now I don't see one.

@mikekistler mikekistler marked this pull request as ready for review September 2, 2025 22:23
@mikekistler mikekistler marked this pull request as draft September 2, 2025 22:26
@mikekistler mikekistler marked this pull request as ready for review September 3, 2025 00:17
@mikekistler
Copy link
Contributor Author

Okay ... I think this is ready for review. @eiriktsarpalis or @halter73

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikekistler mikekistler merged commit acf6eb2 into main Sep 3, 2025
10 checks passed
@mikekistler mikekistler deleted the mdk/build-docs-samples branch September 3, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants