Skip to content

Conversation

@vocatan
Copy link

@vocatan vocatan commented Jan 15, 2016

No description provided.

README.textile Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also specify that this command (with -install) works for 0.x as well:

/tmp/downloads/elasticsearch-0.90.11 → bin/plugin 
Usage:
    -u, --url     [plugin location]   : Set exact URL to download the plugin from
    -i, --install [plugin name]       : Downloads and installs listed plugins [*

Also IMHO --install looks better because that's the variant the is listed in help output of the command and -install is sort of undocumented feature :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good feedback!

On Sun, Jan 24, 2016 at 2:58 PM, Volodymyr Sobotovych <
[email protected]> wrote:

In README.textile
#239 (comment)
:

@@ -10,16 +10,17 @@ There are two main ways of running and installing elasticsearch-head

h4. Running as a plugin of Elasticsearch

-* @sudo elasticsearch/bin/plugin -install mobz/elasticsearch-head@
+* @sudo elasticsearch/bin/plugin -install mobz/elasticsearch-head@ (ES 1.x)

You can also specify that this command (with -install) works for 0.x as
well:

/tmp/downloads/elasticsearch-0.90.11 → bin/plugin
Usage:
-u, --url [plugin location] : Set exact URL to download the plugin from
-i, --install [plugin name] : Downloads and installs listed plugins [*

Also IMHO --install looks better because that's the variant the is listed
in help output of the command and -install is sort of undocumented
feature :)


Reply to this email directly or view it on GitHub
https://github.com/mobz/elasticsearch-head/pull/239/files#r50641089.

…ntages

and that --install matches more closely the 2.x help page
@philipskokoh
Copy link
Collaborator

Thanks for this PR!
ES 2.x does not require -- to install plugin. I will update this later.
https://www.elastic.co/guide/en/elasticsearch/plugins/2.0/installation.html

philipskokoh added a commit that referenced this pull request Jan 28, 2016
very minor typographical corrections
@philipskokoh philipskokoh merged commit acbd3f2 into mobz:master Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants