Skip to content

Conversation

@cmanaha
Copy link
Contributor

@cmanaha cmanaha commented Jan 8, 2016

Additional xhrFields : { withCredentials: True} added to the connection

…nments

Additional xhrFields : { withCredentials: True} added to the connection
mobz added a commit that referenced this pull request Jan 11, 2016
Enabled xhrFields to pass the credentials on SSO authenticated environments
@mobz mobz merged commit 1dbcac4 into mobz:master Jan 11, 2016
@philipskokoh
Copy link
Collaborator

Thanks @sjuvonen for pointing out this issue.
I revert back the PR for now, will get back to address this issue later.

@nz
Copy link

nz commented Feb 18, 2016

withCredentials should be set to true only when actually using credentials.

Some more input on this: withCredentials is needed when you want to pass the entire session with cookies. For best results with CORS, you can do fine by setting an Authorization header, and leave withCredentials = false.

As an ES hosting provider, I definitely don't want people accidentally sending us their users' sessions over HTTP :-)

I helped build out CORS support on bonsai.io and definitely bumped my head on this a few times, happy to help support any efforts around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants