-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
DOC: more website fixes #9202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: more website fixes #9202
Conversation
I think this is a very good idea! |
Renderings so far: Homepage: https://26577-1301584-gh.circle-artifacts.com/0/dev/index.html New funders page: https://26577-1301584-gh.circle-artifacts.com/0/dev/funding.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't know why CIs complain
I still see the footer with all contributed logos? |
I haven't made that change yet, was waiting for feedback (as it's the weekend I thought I should give people until Monday to weigh in) |
To me two things would be nice to preserve on the landing page:
For (1) it would be nice to keep the institutions at the bottom, but if we can't do that, maybe we could just add them to the homepage? Those might look cool in the right bar where the funders used to be. I don't like having them just at the bottom of the main page (non-sticky) because I think most people will never see it, and I think they should be prominent. For (2) I don't like that all of our funders lost prominence -- they're basically hidden and hard to find now. Maybe we should have a second box in the left column (below the version box with link) that just shows the funder logos, and the entire box links to the funders page? |
As mentioned in #8876 (comment), the homepage left sidebar disappears below a certain width. Theme default in that case is to put that inline before the main content which was nixed long ago by @agramfort because you have to scroll past tons of funders before even seeing our logo. The remedy was to not show the left sidebar content at all once it collapses, so anything we put there becomes inaccessible to mobile users. For the "quicklinks" box this is OK because it links to pages that are in the TOCtree, so they are accessible in other ways (though with more clicks) via the main nav. So if it's important to have funders and institutions on the homepage, they can't go in either sidebar. Which leaves the footer, or the main content area below the gallery. Since that's the only thing we haven't tried yet, I'll see if I can work something up that looks nice. Having logos only and linking to a detailed funders page seems like a good approach so I'll try that first. |
Ahh sorry, forgot about that...
I think we have to consider two use cases: mobile and desktop. On mobile, the sidebar disappears, and I'm okay with no funders or institutions being very visible there (or maybe they are at the bottom). On desktop, the sidebar is there, so it would be nice to have a funders box, and maybe an institition box below that. I don't think putting them at the bottom is a good solution because they won't be seen very often. So a workable solution might be to add to the sidebar, but then also have a |
this is the opposite of what @cbrnr expressed (#8876 (comment)) 😖 I'll try your suggestion of big screen -> funders in sidebar, narrow screen -> funders below homepage gallery. This is still not ideal from the perspective of someone using a screen reader, since site content will be in a different order for them depending on which device they're using. |
One way to get a more uniform experience and to promote contributors and funders would be to demote the gallery. For example we could put everything in the main contents with the title box (col-xs-12), then funders (col-sm-12, col-md-6) and contributors (col-sm-12, col-md-6) then the gallery (col-xs-12) or so. |
Overall I'm happy with this change but I don't really like that sponsors and contributors are now off the landing page even on a fairly large (1080p+) screen. I'm starting to come around to the idea @cbrnr originally pushed that we should deviate from the pydata-sphinx-theme on the landing page as it will probably allow us to make everyone (more) happy. For example following NumPy's landing page: We could have logo left with tagline plus a few buttons on the right (currently holding what we have now in the left sidebar) and beneath that examples, then finally funders and contributors. Then the top bar (and anywhere else in the docs) look like pydata-sphinx-theme. I think this gets us a more "intentional" front page that gets us logo + examples + funders + contributors more prominently. From talking to @drammock briefly something like this might be doable but is also a lot more work, so maybe something to try on some future lazy Sunday :) In the meantime let's merge this! |
closes #8876
The only (?) change raised in that issue that isn't addressed here is the "sticky sidebars when scrolling" issue raised by @marsipu. I can't find a config option for it in the theme, so I suspect that it ought to work and I broke it when I made it so that the footer isn't always just off the bottom edge of the screen even on short pages. If I'm right about the cause, then I think maybe the best solution is to ditch our custom footer (with all the institution logos) for something simpler (just the copyright) and revert that scrolling-related theme customization, and then put the list of institutional sponsors only on the new funding page. WDYT @cbrnr @larsoner @agramfort?