-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
MAINT: Standardize tests #10502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
MAINT: Standardize tests #10502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Apr 8, 2022
Member
|
@larsoner I let you merge and backport 🙏 |
larsoner
added a commit
that referenced
this pull request
Apr 8, 2022
larsoner
added a commit
to wmvanvliet/mne-python
that referenced
this pull request
Apr 19, 2022
* upstream/main: (40 commits) FIX: Flake (mne-tools#10540) FIX: Correct link (mne-tools#10536) DOC: Update installers (mne-tools#10535) ENH: Add dark mode to website (mne-tools#10523) WIP: Copy BEM surfaces by default (don't symlink) (mne-tools#10531) Avoid lowpass=0 in brainvision data (mne-tools#10517) DOC: Update installers [skip azp] [skip actions] (mne-tools#10528) FIX: Fix for old build (mne-tools#10527) Fix line noise at wrong frequencies (mne-tools#10525) FIX : read fids in eeglab (mne-tools#10521) MAINT: Prefer PySide6 in testing (mne-tools#10513) ENH: Add overview_mode support (mne-tools#10501) MRG: Updates for qtpy in mne-qt-browser (mne-tools#10509) BUG: Fix bug with themes on macOS (mne-tools#10500) MAINT: Bump installer links (mne-tools#10511) Add metadata to combine_channels (mne-tools#10504) MAINT: Standardize tests (mne-tools#10502) CI: Test circle (mne-tools#10506) ENH: Use HiDPI splash screen on HiDPI screens (mne-tools#10503) WIP,MNT: Add support for QtPy (mne-tools#10430) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on mne-tools/mne-qt-browser#105 I kept getting unexpected errors on CIs. The first time I ran the tests locally on my macOS machine, I could replicate the issue. The second time, however, I could not. I realized this was because the
MNE_BROWSE_RAW_SIZEconfig var on my system was being overwritten (!). This PR fixes this by:_MNE_CONFIG_FAKE_HOME_DIRat thesessionlevel to prevent overwriting people's config varsMNE_BROWSE_RAW_SIZEto standardize browser sizes across all systems. This should make things more repeatable in testing across different people's systems (which could otherwise have different MNE_BROWSE_RAW_SIZE). In an ideal world, this value would not matter, but in practice our_fake_clicks are not so well generalized to arbitrary window sizes.mplandQtto test their own fullscreen methods.)