Skip to content

Conversation

drammock
Copy link
Member

@drammock drammock commented Apr 2, 2025

TODOs (probably incomplete)

  • add pyproject.toml
  • add release workflow
  • create deployment environment (workflow expects name pypi)
  • set required reviewers for environment?
  • create the project on PyPI under MNE org should happen automatically on release
  • create PyPI Trusted Publisher token and add to deploy environment
  • disable the curryreader workflow? (it's run upstream already)

cc @larsoner @dominikwelke

@dominikwelke
Copy link

thanks for pushing this forward @drammock . i had also worked a bit on packaging today, but built manually and with moving files to a src folder so far (see https://github.com/dominikwelke/curry-python-reader/tree/build)

i put my version up on TestPyPI and everything works.
(pip install -i https://test.pypi.org/simple/ curry-python-reader)
but an automatic workflow without touching other files is better of course!

the only relevant file for us is curryreader.py, btw, if you want to exclude more.
also there's only one relevant def in there (curryreader.read)

@drammock
Copy link
Member Author

drammock commented Apr 2, 2025

built manually and with moving files to a src folder so far [...]
but an automatic workflow without touching other files is better of course!

Yeah I was trying to avoid moving/deleting/changing existing files, to simplify the process of merging in upstream changes from compumedics/neuroscan. If you want to play around locally with the changes here, python -m build . in the root directory works, assuming you have relevant packages installed.

@dominikwelke
Copy link

hi @drammock -
can i help in any way to push this forward?

alternatively, i could temporarily publish the version i already packaged on PyPI proper to allow testing of the MNE code.
we can take it down again once this version here is up and running..

@drammock
Copy link
Member Author

can i help in any way to push this forward?

the nudge was good enough. Stand by...

@drammock drammock marked this pull request as ready for review April 14, 2025 15:12
@drammock drammock merged commit 0026abd into mne-tools:main Apr 14, 2025
@drammock drammock deleted the package branch April 14, 2025 15:13
@drammock
Copy link
Member Author

here you go! https://pypi.org/project/curryreader/

@dominikwelke
Copy link

great! thank you @drammock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants