Fix invalid register values in arraycopy_epilogue barrier
#216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the CI results, look like all the generational plans, including StickyImmix, passed all the DaCapo runs. |
|
Yeah it's safe to say from CI results that the bug for generational collectors is fixed. I'll check with our performance parameters + will check what OpenJDK GCs do |
This was referenced Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
arraycopy_epiloguebarrier, thecountordstregister values may get overwritten after the array copy, andarraycopy_epiloguecan receive invalid addresses.This PR adds an
arraycopy_prologuebarrier, saves the register values in this prologue barrier, and restores them inarraycopy_epilogue.This should fix generational plan crashes on some DaCapo benchmarks.