Add a retry mechanism for publishing mmtk-core to crates.io #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wks
approved these changes
Jun 28, 2022
Collaborator
wks
left a comment
wks
left a comment
There was a problem hiding this comment.
LGTM, but there is room for improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds retry in the github workflow for publishing the crates.
As we introduced a sub-crate
mmtk-macrosin #575, we need to publish bothmmtk-macrosandmmtk. What we do for the workflow is that we publishmmtk-macrosfirst, and then publishmmtk. However, in practice, we have seen that the workflow runs failed since the change (v0.12.0 and v0.13.0). The publishing formmtk-macrossucceeded, but the publishing formmtkfailed due to missing the dependency formmtk-macros. I published those two versions manually with simplycargo publish, and it worked fine. I think there could be some delay in crates.io before we can see the new version ofmmtk-macrosthat we publish. Hopefully adding retry for publishingmmtkcan fix this.