-
Notifications
You must be signed in to change notification settings - Fork 78
Update CI for bindings #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
binding-refs: |
7cac21b to
83ac46c
Compare
3f30563 to
bd28103
Compare
bd28103 to
2017a9b
Compare
49693ac to
32da80c
Compare
32da80c to
8f9ac07
Compare
Running benchmarks for JikesRVM...
|
| Benchmark | Trunk(ms) | Branch(ms) | Diff | |||||
|---|---|---|---|---|---|---|---|---|
| mean | mean without outliers | median | mean | mean without outliers | median | mean | mean without outliers | |
| antlr | 1184.83 ±589.61 | 910.56 ±205.10 |
807.0 | 810.38 ±9.96 | 810.38 ±9.96 | 806.0 | -31.60% | -11.00% 🟩 |
| fop | 623.52 ±2.76 | 622.59 ±2.06 |
622.5 | 620.35 ±1.37 | 620.35 ±1.37 | 620.0 | -0.51% | -0.36% |
| luindex | 2245.50 ±8.31 | 2245.50 ±8.31 | 2243.5 | 2251.45 ±8.14 | 2251.45 ±8.14 | 2253.0 | +0.26% | +0.26% |
SemiSpace (wrench-2022-02-22-Tue-164055)
| Benchmark | Trunk(ms) | Branch(ms) | Diff | |||||
|---|---|---|---|---|---|---|---|---|
| mean | mean without outliers | median | mean | mean without outliers | median | mean | mean without outliers | |
| antlr | 641.77 ±10.48 | 639.28 ±9.44 |
646.0 | 643.90 ±10.72 | 643.90 ±10.72 | 641.0 | +0.33% | +0.72% |
| bloat | 2212.81 ±23.78 |
2212.81 ±23.78 | 2238.0 | 2225.28 ±21.10 |
2225.28 ±21.10 | 2245.5 | +0.56% | +0.56% |
| fop | 587.35 ±2.45 | 587.35 ±2.45 | 586.0 | 591.20 ±5.07 | 589.23 ±3.22 |
587.0 | +0.66% | +0.32% |
| hsqldb | 547.57 ±10.84 |
541.34 ±6.70 |
538.0 | 538.32 ±2.28 |
537.73 ±2.01 |
537.5 | -1.69% | -0.67% |
| jython | 1628.92 ±9.54 |
1628.92 ±9.54 | 1625.0 | 1629.78 ±8.90 |
1629.78 ±8.90 | 1632.0 | +0.05% | +0.05% |
| luindex | 2277.46 ±7.95 |
2277.46 ±7.95 | 2281.0 | 2275.97 ±6.34 |
2275.97 ±6.34 | 2278.5 | -0.07% | -0.07% |
| lusearch | 437.33 ±11.44 |
434.45 ±10.11 |
433.0 | 430.10 ±10.37 |
430.10 ±10.37 | 421.0 | -1.65% | -1.00% 🟩 |
| pmd | 1204.90 ±7.14 | 1204.90 ±7.14 | 1209.0 | 1202.21 ±6.59 |
1202.21 ±6.59 | 1200.0 | -0.22% | -0.22% |
| xalan | 458.57 ±2.92 | 457.69 ±2.37 |
459.0 | 459.23 ±2.91 | 459.23 ±2.91 | 461.5 | +0.14% | +0.33% |
Running benchmarks for OpenJDK...
|
| Benchmark | Trunk(ms) | Branch(ms) | Diff | |||||
|---|---|---|---|---|---|---|---|---|
| mean | mean without outliers | median | mean | mean without outliers | median | mean | mean without outliers | |
| antlr | 389.38 ±7.71 |
385.22 ±5.26 |
380.0 | 391.74 ±9.51 |
389.11 ±8.09 |
381.0 | +0.61% | +1.01% 🟥 |
| eclipse | 7402.27 ±15.35 | 7402.27 ±15.35 | 7383.0 | 7415.00 ±33.35 | 7399.97 ±14.10 |
7386.5 | +0.17% | -0.03% |
| fop | 467.20 ±3.10 | 466.41 ±2.73 |
463.0 | 465.10 ±3.35 | 464.18 ±2.87 |
461.5 | -0.45% | -0.48% |
| hsqldb | 433.48 ±2.94 | 431.82 ±1.88 |
432.0 | 433.38 ±3.41 | 433.38 ±3.41 | 430.0 | -0.02% | +0.36% |
| pmd | 1223.75 ±5.15 | 1222.51 ±4.63 |
1219.5 | 1225.33 ±5.42 | 1223.74 ±4.50 |
1220.5 | +0.13% | +0.10% |
GenCopy (hammer-2022-02-22-Tue-191027)
| Benchmark | Trunk(ms) | Branch(ms) | Diff | |||||
|---|---|---|---|---|---|---|---|---|
| mean | mean without outliers | median | mean | mean without outliers | median | mean | mean without outliers | |
| antlr | 391.23 ±0.65 | 391.23 ±0.65 | 391.0 | 392.07 ±1.02 | 391.72 ±0.74 |
392.0 | +0.22% | +0.13% |
| eclipse | 7822.12 ±17.33 | 7815.97 ±12.39 |
7816.0 | 7807.32 ±14.33 | 7802.08 ±9.88 |
7812.5 | -0.19% | -0.18% |
| fop | 467.57 ±0.84 | 467.31 ±0.66 |
467.5 | 467.32 ±0.54 | 467.32 ±0.54 | 467.0 | -0.05% | +0.00% |
| hsqldb | 366.30 ±3.07 | 366.30 ±3.07 | 367.0 | 364.52 ±2.82 | 364.52 ±2.82 | 365.0 | -0.48% | -0.48% |
| pmd | 1397.47 ±10.69 | 1397.47 ±10.69 | 1388.5 | 1388.78 ±10.75 | 1388.78 ±10.75 | 1384.0 | -0.62% | -0.62% |
wks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly OK except some minor style problem.
wks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR mainly makes changes to CI configs to cooperate with the bindings' change of removing VM submodules (mmtk/mmtk-jikesrvm#101 and mmtk/mmtk-openjdk#140).
Changes:
ci-checkout.shafter checking out binding repos for OpenJDK and JikesRVMci-perf-kitto 0.6.6, which changes the command line arguments used for JikesRVM (we no longer support setting MMTk options with camelCase - the fix changes options to snake_case).Related PRs: