Skip to content

Conversation

@qinsoon
Copy link
Member

@qinsoon qinsoon commented Feb 18, 2022

This PR mainly makes changes to CI configs to cooperate with the bindings' change of removing VM submodules (mmtk/mmtk-jikesrvm#101 and mmtk/mmtk-openjdk#140).

Changes:

  • Made CI call ci-checkout.sh after checking out binding repos for OpenJDK and JikesRVM
  • Changed how we collect binding info:
    • Now we use a reusable workflow to extract binding info (repos and refs) from one comment in a PR.
    • The workflow is used by both binding correctness tests and benchmarks.
    • Our CI now can run tests and benchmarks for binding PRs submitted from a fork.
    • This closes Run CI checks with a binding PR from a fork #246.
  • Updated porting guide for a more logically correct folder structure.
  • Updated ci-perf-kit to 0.6.6, which changes the command line arguments used for JikesRVM (we no longer support setting MMTk options with camelCase - the fix changes options to snake_case).

Related PRs:

@qinsoon
Copy link
Member Author

qinsoon commented Feb 18, 2022

binding-refs:
OPENJDK_BINDING_REPO=qinsoon/mmtk-openjdk
OPENJDK_BINDING_REF=remove-vm-submodule
JIKESRVM_BINDING_REF=remove-vm-submodule
V8_BINDING_REF=reusable-workflow

@qinsoon qinsoon added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Feb 18, 2022
@qinsoon qinsoon force-pushed the update-ci-for-bindings branch from 7cac21b to 83ac46c Compare February 21, 2022 03:40
@qinsoon qinsoon removed the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Feb 21, 2022
@qinsoon qinsoon force-pushed the update-ci-for-bindings branch 5 times, most recently from 3f30563 to bd28103 Compare February 21, 2022 21:45
@qinsoon qinsoon force-pushed the update-ci-for-bindings branch from bd28103 to 2017a9b Compare February 21, 2022 23:45
@qinsoon qinsoon added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Feb 22, 2022
@qinsoon qinsoon force-pushed the update-ci-for-bindings branch from 49693ac to 32da80c Compare February 22, 2022 04:36
@qinsoon qinsoon force-pushed the update-ci-for-bindings branch from 32da80c to 8f9ac07 Compare February 22, 2022 04:48
@mmtkgc-bot
Copy link

mmtkgc-bot commented Feb 22, 2022

Running benchmarks for JikesRVM...
JikesRVM

NoGC (wrench-2022-02-22-Tue-162845)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 1184.83 ±589.61 910.56 ±205.10 ⚠️ 1 removed 807.0 810.38 ±9.96 810.38 ±9.96 806.0 -31.60% -11.00% 🟩
fop 623.52 ±2.76 622.59 ±2.06 ⚠️ 1 removed 622.5 620.35 ±1.37 620.35 ±1.37 620.0 -0.51% -0.36%
luindex 2245.50 ±8.31 2245.50 ±8.31 2243.5 2251.45 ±8.14 2251.45 ±8.14 2253.0 +0.26% +0.26%

SemiSpace (wrench-2022-02-22-Tue-164055)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 641.77 ±10.48 639.28 ±9.44 ⚠️ 1 removed 646.0 643.90 ±10.72 643.90 ±10.72 641.0 +0.33% +0.72%
bloat 2212.81 ±23.78 ⚠️ 9/40 failed 2212.81 ±23.78 2238.0 2225.28 ±21.10 ⚠️ 4/40 failed 2225.28 ±21.10 2245.5 +0.56% +0.56%
fop 587.35 ±2.45 587.35 ±2.45 586.0 591.20 ±5.07 589.23 ±3.22 ⚠️ 1 removed 587.0 +0.66% +0.32%
hsqldb 547.57 ±10.84 ⚠️ 3/40 failed 541.34 ±6.70 ⚠️ 2 removed 538.0 538.32 ±2.28 ⚠️ 2/40 failed 537.73 ±2.01 ⚠️ 1 removed 537.5 -1.69% -0.67%
jython 1628.92 ±9.54 ⚠️ 1/40 failed 1628.92 ±9.54 1625.0 1629.78 ±8.90 ⚠️ 4/40 failed 1629.78 ±8.90 1632.0 +0.05% +0.05%
luindex 2277.46 ±7.95 ⚠️ 5/40 failed 2277.46 ±7.95 2281.0 2275.97 ±6.34 ⚠️ 4/40 failed 2275.97 ±6.34 2278.5 -0.07% -0.07%
lusearch 437.33 ±11.44 ⚠️ 1/40 failed 434.45 ±10.11 ⚠️ 1 removed 433.0 430.10 ±10.37 ⚠️ 1/40 failed 430.10 ±10.37 421.0 -1.65% -1.00% 🟩
pmd 1204.90 ±7.14 1204.90 ±7.14 1209.0 1202.21 ±6.59 ⚠️ 2/40 failed 1202.21 ±6.59 1200.0 -0.22% -0.22%
xalan 458.57 ±2.92 457.69 ±2.37 ⚠️ 1 removed 459.0 459.23 ±2.91 459.23 ±2.91 461.5 +0.14% +0.33%

@mmtkgc-bot
Copy link

mmtkgc-bot commented Feb 22, 2022

Running benchmarks for OpenJDK...
OpenJDK

SemiSpace (hammer-2022-02-22-Tue-171334)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 389.38 ±7.71 ⚠️ 1/40 failed 385.22 ±5.26 ⚠️ 2 removed 380.0 391.74 ±9.51 ⚠️ 1/40 failed 389.11 ±8.09 ⚠️ 1 removed 381.0 +0.61% +1.01% 🟥
eclipse 7402.27 ±15.35 7402.27 ±15.35 7383.0 7415.00 ±33.35 7399.97 ±14.10 ⚠️ 1 removed 7386.5 +0.17% -0.03%
fop 467.20 ±3.10 466.41 ±2.73 ⚠️ 1 removed 463.0 465.10 ±3.35 464.18 ±2.87 ⚠️ 1 removed 461.5 -0.45% -0.48%
hsqldb 433.48 ±2.94 431.82 ±1.88 ⚠️ 2 removed 432.0 433.38 ±3.41 433.38 ±3.41 430.0 -0.02% +0.36%
pmd 1223.75 ±5.15 1222.51 ±4.63 ⚠️ 1 removed 1219.5 1225.33 ±5.42 1223.74 ±4.50 ⚠️ 1 removed 1220.5 +0.13% +0.10%

GenCopy (hammer-2022-02-22-Tue-191027)

Benchmark Trunk(ms) Branch(ms) Diff
mean mean without outliers median mean mean without outliers median mean mean without outliers
antlr 391.23 ±0.65 391.23 ±0.65 391.0 392.07 ±1.02 391.72 ±0.74 ⚠️ 1 removed 392.0 +0.22% +0.13%
eclipse 7822.12 ±17.33 7815.97 ±12.39 ⚠️ 1 removed 7816.0 7807.32 ±14.33 7802.08 ±9.88 ⚠️ 1 removed 7812.5 -0.19% -0.18%
fop 467.57 ±0.84 467.31 ±0.66 ⚠️ 1 removed 467.5 467.32 ±0.54 467.32 ±0.54 467.0 -0.05% +0.00%
hsqldb 366.30 ±3.07 366.30 ±3.07 367.0 364.52 ±2.82 364.52 ±2.82 365.0 -0.48% -0.48%
pmd 1397.47 ±10.69 1397.47 ±10.69 1388.5 1388.78 ±10.75 1388.78 ±10.75 1384.0 -0.62% -0.62%

@qinsoon qinsoon marked this pull request as ready for review February 23, 2022 02:44
@qinsoon qinsoon requested a review from wks February 23, 2022 02:44
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly OK except some minor style problem.

Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit dbd152b into master Feb 25, 2022
@qinsoon qinsoon deleted the update-ci-for-bindings branch February 25, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Porting guide implies the use of submodules for mmtk-core and VM repos Run CI checks with a binding PR from a fork

4 participants