Skip to content

Fix build with stock GC: mmtk_pin_object should be conditionaly compiled #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix build with stock GC: mmtk_pin_object should be conditionaly compiled #42

merged 1 commit into from
Mar 1, 2024

Conversation

@qinsoon
Copy link
Member

@qinsoon qinsoon commented Mar 1, 2024

No description provided.

@qinsoon qinsoon requested a review from udesou March 1, 2024 01:05
udesou
udesou approved these changes Mar 1, 2024
View reviewed changes
Copy link

@udesou udesou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qinsoon qinsoon merged commit 48d7e42 into mmtk:v1.9.2+RAI Mar 1, 2024
qinsoon added a commit to qinsoon/julia that referenced this pull request Mar 27, 2024
@qinsoon
Fix build with stock GC: mmtk_pin_object is conditionaly compiled (mm…
d19af7c 
…tk#42)
qinsoon added a commit to qinsoon/julia that referenced this pull request May 6, 2024
@qinsoon
Fix build with stock GC: mmtk_pin_object is conditionaly compiled (mm…
679dc42 
…tk#42)
@qinsoon qinsoon mentioned this pull request May 6, 2024
Merged
qinsoon added a commit that referenced this pull request May 10, 2024
@qinsoon
Port PR #42 and #44 to master (#48)
d907a06 
* Call initialize_collection before enabling GC (#44)
* Fix build with stock GC: mmtk_pin_object is conditionaly compiled (#42)
udesou pushed a commit to udesou/julia that referenced this pull request Aug 19, 2024
@topolarity @JeffBezanson
improve inference of CPU_THREADS in Sys.__init__ (JuliaLang#54384)
99bda02 
Without this change, the compiler fails to notice that `env_threads isa
Int` in the fall-through case, leading to a union-split with a branch
that is in fact unreachable:

```
43 ┄ %109 = φ (mmtk#41 => %105, mmtk#42 => %108)::Union{Nothing, Int64}
│    %110 = (%109 isa Int64)::Bool
└───        goto mmtk#45 if not %110
...
45 ─ %126 = π (%109, Nothing)
│           Base.convert(Int64, %126)::Union{}
└───        unreachable
```

After this change, the union-split is eliminated.

Co-authored-by: Jeff Bezanson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@udesou udesou udesou approved these changes

Assignees

No one assigned

Labels

port-to-master port-to-v1.9 port-to-v1.10

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qinsoon @udesou