Skip to content

Add support/testing for PHP 8.1 #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2021
Merged

Add support/testing for PHP 8.1 #272

merged 2 commits into from
Jun 30, 2021

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jan 24, 2021 •
edited
Loading

fixes #271

@mlocati
Copy link
Owner

mlocati commented Jan 24, 2021

I guess tests won't complete because of timeout

@mvorisek mvorisek mentioned this pull request Jan 25, 2021
Closed
@mvorisek
Copy link
Contributor Author

I guess tests won't complete because of timeout

related with: #275, to overcome the timeout I now added support for extensions provided directly from php sources, which should always compile. Once this PR is merged, I will add support for other extensions in another PR.

@mvorisek
Copy link
Contributor Author

given the efford to maintain this and not having full support to mark specific job as informative only - see actions/runner#2347 , I am closing this for now

@mvorisek mvorisek closed this Jan 25, 2021
@mvorisek mvorisek deleted the add_nightly_php_support branch January 25, 2021 12:32
@mlocati
Copy link
Owner

mlocati commented Jan 25, 2021

Yep, I'd wait that PHP 8.1 becomes a bit more stable (that is, at least in the beta stage).

@mvorisek mvorisek restored the add_nightly_php_support branch June 29, 2021 06:45
@mvorisek mvorisek reopened this Jun 29, 2021
@mvorisek mvorisek changed the title Add support for PHP 8.1-dev / nightly Add support for PHP 8.1 Jun 29, 2021
@mvorisek mvorisek changed the title Add support for PHP 8.1 Add support/testing for PHP 8.1 Jun 29, 2021
@mvorisek mvorisek marked this pull request as ready for review June 29, 2021 11:37
@mvorisek
Copy link
Contributor Author

@mlocati PR is passing, most of the extensions are from php-src, thus the build should always pass, can we merge it to reduce the testing time of other extensions?

@mlocati
Copy link
Owner

mlocati commented Jun 29, 2021

Sure! I'll wait that those last tests pass

@mvorisek mvorisek closed this Jun 29, 2021
@mvorisek mvorisek reopened this Jun 29, 2021
@mvorisek
Copy link
Contributor Author

The CI should be passing, Check on alpine3.12 issue seems to be related with cached PHP 8.1 alpha1 image, alpha2 is fixed.

@mlocati
Copy link
Owner

mlocati commented Jun 30, 2021

The CI should be passing, Check on alpine3.12 issue seems to be related with cached PHP 8.1 alpha1 image, alpha2 is fixed.

I restarted the CI jobs

@mvorisek
Copy link
Contributor Author

Alpine v3.12 images are no longer updated.

See docker-library/php#1166 and related pulled tag https://hub.docker.com/_/php?tab=tags&page=1&ordering=last_updated&name=8.1-rc-cli-alpine3.12

Can you please adjust the test script that PHP 8.1+ is not tested againt Alpine 3.12?

@mlocati
Don't run tests for PHP 8.1 on Alpine Linux 3.12
497296e 
They don't update the PHP version on that image, it will remain at 8.1.0-alpha1
@mlocati mlocati merged commit 3a8bb5d into mlocati:master Jun 30, 2021
@mvorisek mvorisek deleted the add_nightly_php_support branch June 30, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PHP 8.1 support
2 participants
@mvorisek @mlocati