[nn-refactor] Refactor and reimplementation of NeuralNetwork #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2019
shiffman
approved these changes
Dec 11, 2019
Member
shiffman
left a comment
shiffman
left a comment
There was a problem hiding this comment.
This looks wonderful, thank you @joeyklee! I just scanned it over and I think the refactoring is all in the right direction. I commented on some minor nitpicky things in the corresponding ml5-examples pull request. I am going to make a new pose classifier example tomorrow so can test this out with it then!
Contributor
Author
|
A few issues popping up:
getMin(_array) {
// return Math.min(..._array)
return _array.reduce((a, b) => {
return Math.min(a, b);
});
}
|
Contributor
Author
|
@shiffman I will merge this in now and plan to do subsequent assessments of the updates and refactoring. There's def. some optimizations that can be made, but I think it is structurally more stable than before as well as has the beginnings of a balanced "constrained flexibility" to do enough but not too much/everything. I'm excited to see what happens! |
joeyklee
added a commit
that referenced
this pull request
Jan 5, 2020
* [nn-refactor] Refactor and reimplementation of NeuralNetwork (#749) * adds temp DiyNeuralNetwork - refactoring NeuralNetwork class * adds updates to refactor * refactoring nn-refactor * adds features for compile and add layers * rm console log * adds train interface * adds basic predict * adds blank functions in data class * update nn class * adds nn compile handling * updates function name * adds data loading functions // todo - clean up * add recursive findEntries function and data loading functions * adds formatRawData function * adds .addData() function * adds saveData function * adds handling for onehot and counting input and output units " " * adds code comments * adds concat to this.meta * changed name to createMetaDataFromData" * adds convertRawToTensors * adds functions for calculating stats * adds normalization and conversion to tensor handling * adds .summarizeData * adds data handling to index * updates summarizeData function to explicitly set meta * updates and adds functions * updates predict function * adds classify() with meta * adds metadata handling and data functions * adds loadData with options in init * adds major updates to initiation and defaults * adds boolean flags to check status to configure nn * adds addData function to index * adds support for auto labeling inputs and outputs for blank nn * code cleanup and function name change * flattens array in cnvertRawToTensors * flattens inputs * flatten array always * adds isOneHotEncodedOrNormalized * updates predict and classify functions and output format * updates param handling in predict and classify * code cleanup * adds save function * code cleanup * adds first pass at loading data * fixes missing isNormalized flag in meta * moves loading functions to respective class * moves files to NeuralNetwork * moves files to NeuralNetwork and rm diyNN * rms console.log * check if metadata and warmedup are true before normalization * adds unnormalize function to nn predict * return unNormalized value * adds loadData() and changes to loadDataFromUrl * adds saveData to index * adds modelUrl to constructor options in index * cleans up predict and classify * fix reference to unNormalizeValue * code cleanup * adds looping to format data for prediction and predictMultiple and classifyMultiple * adds layer handling for options * adds tfvis to index and ml5 root * adds debug flag in options * adds vis and fixes input formatting" " * adds model summary * adds comments and reorders code * refactoring functions with 3 datatypes in mind: number, string, array * adds data handling updates * adds handling tensors * adds process up to training * fixes breaking training * adds full working poc * fix addData check * adds updates to api and notes to fix with functions * adds createMetadata in index * adds image handling in classify functino * adds method to not exceed call stack of min and max * fixes loadData issue * adds first header name for min and max * code cleanup * removes unused functions * fixes setDataRaw * code clean up, organization, and adds method binding to constructor * adds methods to constructor, adds comments, and cleans up * adds methods to constructor for nndata * adds methods to constructor, code cleanup, and organization * docs: add RaisinTen as a contributor (#751) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * [neural network] adds first tests for neural network and placeholders (#755) * initial commit for nn test * sets karma testing random to false * adds tests for neuralnetwork class * adds placeholders for tests to do * docs: add LudwigStumpp as a contributor (#758) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * fix(Docsify Configuration (docs/index.html)): Use Docsify's auto2top property to reset scroll positi (#761) * docs(feature-extractor.md): Switch the links for regression and classifications p5 editor examples i (#762) * docs: add bomanimc as a contributor (#763) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: Joey Lee <[email protected]> * fix: typo Co-authored-by: Joey Lee <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Bomani Oseni McClendon <[email protected]>
bomanimc
added a commit
that referenced
this pull request
Mar 12, 2020
* [nn-refactor] Refactor and reimplementation of NeuralNetwork (#749) * adds temp DiyNeuralNetwork - refactoring NeuralNetwork class * adds updates to refactor * refactoring nn-refactor * adds features for compile and add layers * rm console log * adds train interface * adds basic predict * adds blank functions in data class * update nn class * adds nn compile handling * updates function name * adds data loading functions // todo - clean up * add recursive findEntries function and data loading functions * adds formatRawData function * adds .addData() function * adds saveData function * adds handling for onehot and counting input and output units " " * adds code comments * adds concat to this.meta * changed name to createMetaDataFromData" * adds convertRawToTensors * adds functions for calculating stats * adds normalization and conversion to tensor handling * adds .summarizeData * adds data handling to index * updates summarizeData function to explicitly set meta * updates and adds functions * updates predict function * adds classify() with meta * adds metadata handling and data functions * adds loadData with options in init * adds major updates to initiation and defaults * adds boolean flags to check status to configure nn * adds addData function to index * adds support for auto labeling inputs and outputs for blank nn * code cleanup and function name change * flattens array in cnvertRawToTensors * flattens inputs * flatten array always * adds isOneHotEncodedOrNormalized * updates predict and classify functions and output format * updates param handling in predict and classify * code cleanup * adds save function * code cleanup * adds first pass at loading data * fixes missing isNormalized flag in meta * moves loading functions to respective class * moves files to NeuralNetwork * moves files to NeuralNetwork and rm diyNN * rms console.log * check if metadata and warmedup are true before normalization * adds unnormalize function to nn predict * return unNormalized value * adds loadData() and changes to loadDataFromUrl * adds saveData to index * adds modelUrl to constructor options in index * cleans up predict and classify * fix reference to unNormalizeValue * code cleanup * adds looping to format data for prediction and predictMultiple and classifyMultiple * adds layer handling for options * adds tfvis to index and ml5 root * adds debug flag in options * adds vis and fixes input formatting" " * adds model summary * adds comments and reorders code * refactoring functions with 3 datatypes in mind: number, string, array * adds data handling updates * adds handling tensors * adds process up to training * fixes breaking training * adds full working poc * fix addData check * adds updates to api and notes to fix with functions * adds createMetadata in index * adds image handling in classify functino * adds method to not exceed call stack of min and max * fixes loadData issue * adds first header name for min and max * code cleanup * removes unused functions * fixes setDataRaw * code clean up, organization, and adds method binding to constructor * adds methods to constructor, adds comments, and cleans up * adds methods to constructor for nndata * adds methods to constructor, code cleanup, and organization * docs: add RaisinTen as a contributor (#751) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * [neural network] adds first tests for neural network and placeholders (#755) * initial commit for nn test * sets karma testing random to false * adds tests for neuralnetwork class * adds placeholders for tests to do * docs: add LudwigStumpp as a contributor (#758) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * fix(Docsify Configuration (docs/index.html)): Use Docsify's auto2top property to reset scroll positi (#761) * docs(feature-extractor.md): Switch the links for regression and classifications p5 editor examples i (#762) * docs: add bomanimc as a contributor (#763) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: Joey Lee <[email protected]> * fix: typo Co-authored-by: Joey Lee <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Bomani Oseni McClendon <[email protected]>
bomanimc
added a commit
that referenced
this pull request
Mar 12, 2020
* [nn-refactor] Refactor and reimplementation of NeuralNetwork (#749) * adds temp DiyNeuralNetwork - refactoring NeuralNetwork class * adds updates to refactor * refactoring nn-refactor * adds features for compile and add layers * rm console log * adds train interface * adds basic predict * adds blank functions in data class * update nn class * adds nn compile handling * updates function name * adds data loading functions // todo - clean up * add recursive findEntries function and data loading functions * adds formatRawData function * adds .addData() function * adds saveData function * adds handling for onehot and counting input and output units " " * adds code comments * adds concat to this.meta * changed name to createMetaDataFromData" * adds convertRawToTensors * adds functions for calculating stats * adds normalization and conversion to tensor handling * adds .summarizeData * adds data handling to index * updates summarizeData function to explicitly set meta * updates and adds functions * updates predict function * adds classify() with meta * adds metadata handling and data functions * adds loadData with options in init * adds major updates to initiation and defaults * adds boolean flags to check status to configure nn * adds addData function to index * adds support for auto labeling inputs and outputs for blank nn * code cleanup and function name change * flattens array in cnvertRawToTensors * flattens inputs * flatten array always * adds isOneHotEncodedOrNormalized * updates predict and classify functions and output format * updates param handling in predict and classify * code cleanup * adds save function * code cleanup * adds first pass at loading data * fixes missing isNormalized flag in meta * moves loading functions to respective class * moves files to NeuralNetwork * moves files to NeuralNetwork and rm diyNN * rms console.log * check if metadata and warmedup are true before normalization * adds unnormalize function to nn predict * return unNormalized value * adds loadData() and changes to loadDataFromUrl * adds saveData to index * adds modelUrl to constructor options in index * cleans up predict and classify * fix reference to unNormalizeValue * code cleanup * adds looping to format data for prediction and predictMultiple and classifyMultiple * adds layer handling for options * adds tfvis to index and ml5 root * adds debug flag in options * adds vis and fixes input formatting" " * adds model summary * adds comments and reorders code * refactoring functions with 3 datatypes in mind: number, string, array * adds data handling updates * adds handling tensors * adds process up to training * fixes breaking training * adds full working poc * fix addData check * adds updates to api and notes to fix with functions * adds createMetadata in index * adds image handling in classify functino * adds method to not exceed call stack of min and max * fixes loadData issue * adds first header name for min and max * code cleanup * removes unused functions * fixes setDataRaw * code clean up, organization, and adds method binding to constructor * adds methods to constructor, adds comments, and cleans up * adds methods to constructor for nndata * adds methods to constructor, code cleanup, and organization * docs: add RaisinTen as a contributor (#751) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * [neural network] adds first tests for neural network and placeholders (#755) * initial commit for nn test * sets karma testing random to false * adds tests for neuralnetwork class * adds placeholders for tests to do * docs: add LudwigStumpp as a contributor (#758) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * fix(Docsify Configuration (docs/index.html)): Use Docsify's auto2top property to reset scroll positi (#761) * docs(feature-extractor.md): Switch the links for regression and classifications p5 editor examples i (#762) * docs: add bomanimc as a contributor (#763) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: Joey Lee <[email protected]> * fix: typo Co-authored-by: Joey Lee <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Bomani Oseni McClendon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear ml5 community,
I'm making a Pull Request(PR). Please see the details below.
A good PR 🌟
→ Step 1: Which branch are you submitting to? 🌲
→ Step 2: Describe your Pull Request 📝
Updates:
A great PR 🌟🌟
→ Step 3: Share a Relevant Example 🦄