Expect tests don't work with the ES6 / ES2015 Set object

[trevordmiller]

Issue

The test below should fail, but it is passing:

it('should fail', () => {
  const actual = new Set('a');
  const expected = new Set('b');
  expect(actual).toEqual(expected);
});

Background & Question

I'm using the expect package from npm. I'm using Babel 5 to use Set. I'm using Node 5, so the Set being used should be native.
Am I doing something wrong, or does this look like a bug in the expect package in the way it handles Sets? I've cross posted a Stack Overflow question as I'm not sure.

p.s. I love this package and am happy I don't have to use Chai. Thank you for building it!

[mjackson]

Hi @trevordmiller – thanks for the bug report!

Under the hood we're just using deepEqual to check for equality, so we should probably open a bug report on https://github.com/substack/node-deep-equal.

[mjackson]

BTW, please be sure to reference this issue when you do so we know when we should upgrade. Thanks!

[mjackson]

Oh, wait. I just re-read your original post.

I would actually expect that test to pass. toEqual checks for equal values, but they don't have to be the same object. Use toBe for that.

[rstacruz]

I don't think that test should pass:

var a = new Set('a');
var b = new Set('b');

any way you look at it, equivalence or equality, they should be false. They're 2 different objects with 2 different values.

[mjackson]

Blah, sorry. You guys are right. I need to read more closely next time :P

Let's definitely open an issue on deep-equal and follow up there.

[mjackson]

Released in v 1.13.1

[trevordmiller]

@mjackson Works great now! Thank you so much.