Skip to content

config: Remove syslog handler #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

config: Remove syslog handler #2250

merged 1 commit into from
May 15, 2025

Conversation

blarghmatey
Copy link
Member

What are the relevant tickets?

N/A

Description (What does it do?)

Remove syslog handler for logging

How can this be tested?

Verify that logs are still displayed in docker-compose output

Additional Context

Now that this app is not running on Heroku there's no need to use the syslog handler

@blarghmatey blarghmatey requested review from rhysyngsun and Copilot May 14, 2025 19:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the syslog handler from the logging configuration since the app no longer runs on Heroku.

  • Removed syslog host and port configuration
  • Removed the syslog handler block from the logging handlers configuration
  • Updated the root logger to no longer include the syslog handler

Now that this app is not running on Heroku there's no need to use the syslog handler
Copy link
Contributor

@rhysyngsun rhysyngsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blarghmatey blarghmatey merged commit cda22e8 into main May 15, 2025
13 checks passed
@blarghmatey blarghmatey deleted the tm/k8s_logging branch May 15, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants