Skip to content

Fix flaky test #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

Fix flaky test #2246

merged 2 commits into from
May 13, 2025

Conversation

shanbady
Copy link
Contributor

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/7312

Description (What does it do?)

This is a tiny PR to sort lists in profiles/serializers_test.py::test_serialize_profile_preference_search_filters to resolve flakiness

How can this be tested?

Tests should always pass

@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label May 12, 2025
@shanbady shanbady marked this pull request as ready for review May 12, 2025 18:16
poetry.lock Outdated
@@ -1,12 +1,11 @@
# This file is automatically @generated by Poetry 2.1.2 and should not be changed by hand.
# This file is automatically @generated by Poetry 1.8.5 and should not be changed by hand.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the poetry.lock file was committed by mistake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. must have snuck in while doing renovate items and switching branches. removed

Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to the test looks good

@shanbady shanbady requested a review from abeglova May 13, 2025 14:08
Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shanbady shanbady merged commit c8508d4 into main May 13, 2025
13 checks passed
@shanbady shanbady deleted the shanbady/flaky-profile-app-test branch May 13, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review An open Pull Request that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants