Skip to content

Use more clearly fake data for ci #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Use more clearly fake data for ci #2226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,11 @@ jobs:
run: yarn workspace main build
env:
NODE_ENV: production
NEXT_PUBLIC_ORIGIN: https://ci.learn.mit.edu
NEXT_PUBLIC_MITOL_API_BASE_URL: https://api.ci.learn.mit.edu
NEXT_PUBLIC_ORIGIN: https://cifake.learn.mit.edu
NEXT_PUBLIC_MITOL_API_BASE_URL: https://api.cifake.learn.mit.edu
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://ci.learn.mit.edu is, at time of writing, a heroku app, though https://api.ci.learn.mit.edu doesn't seem to be

Intent here was not to hit actual servers.

This change makes the CI nextjs build take about 90 seconds, which it had been previously compared to:

NEXT_PUBLIC_CSRF_COOKIE_NAME: cookie-monster
NEXT_PUBLIC_SITE_NAME: MIT Learn
NEXT_PUBLIC_MITOL_SUPPORT_EMAIL: help@ci.learn.mit.edu
NEXT_PUBLIC_MITOL_SUPPORT_EMAIL: help@citest.learn.mit.edu
# do this before typecheck. See https://github.com/vercel/next.js/issues/53959#issuecomment-1735563224

- name: Typecheck
Expand Down
Loading