Use more clearly fake data for ci #2226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAPI ChangesShow/hide No detectable change. |
ChristopherChudzicki
force-pushed
the
cc/more-fake-test-urls
branch
from
9ba6c59 to
2ed9073
Compare
OpenAPI ChangesShow/hide No detectable change. |
| NEXT_PUBLIC_ORIGIN: https://ci.learn.mit.edu | ||
| NEXT_PUBLIC_MITOL_API_BASE_URL: https://api.ci.learn.mit.edu | ||
| NEXT_PUBLIC_ORIGIN: https://cifake.learn.mit.edu | ||
| NEXT_PUBLIC_MITOL_API_BASE_URL: https://api.cifake.learn.mit.edu |
There was a problem hiding this comment.
https://ci.learn.mit.edu is, at time of writing, a heroku app, though https://api.ci.learn.mit.edu doesn't seem to be
Intent here was not to hit actual servers.
This change makes the CI nextjs build take about 90 seconds, which it had been previously compared to:
- timeouts on
mainduring CI https://github.com/mitodl/mit-learn/actions/runs/14804003164/job/41659631667 - 8+ minutes here, where I increased the timeout https://github.com/mitodl/mit-learn/actions/runs/14840635669/job/41663769998
ChristopherChudzicki
changed the title
jonkafton
approved these changes
May 5, 2025
This was referenced May 6, 2025
Closed
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
None
Description (What does it do?)
This seems to resolve a build issue during CI, though I don't have a great explanation.
See comment on code.
How can this be tested?
CI should pass.