Fix SCIM view tests

[rhysyngsun]

What are the relevant tickets?

N/A

Description (What does it do?)

Fixes the SCIM tests that broke because of 2 PRs being merged in rapid succession.

How can this be tested?

Tests should pass.

[gemini-code-assist]

Hello @rhysyngsun, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses and fixes broken SCIM (System for Cross-domain Identity Management) tests. The tests were failing due to recent changes introduced by two merged pull requests. The primary changes involve updating the tests to align with the new data structure, specifically referencing user attributes directly instead of accessing them through the user's profile.

Highlights

• Test Fix: Addresses broken SCIM tests caused by recent updates.
• Data Structure Alignment: Updates tests to directly reference user attributes instead of accessing them through the profile.
• Factory Updates: Adds scim_external_id and scim_username to the UserFactory for test data generation.

Changelog

• main/factories.py
  • Imported SelfAttribute to define scim_username based on the user's email.
  • Added scim_external_id using Faker to generate a UUID.
  • Added scim_username using SelfAttribute to copy the email to the username.
• scim/views_test.py
  • Modified the test assertions to directly access user.scim_id instead of user.profile.scim_id.
  • Modified the test assertions to directly access user.scim_external_id instead of user.profile.scim_external_id.
  • Modified the test assertions to directly access user.updated_on instead of user.profile.updated_at.
  • Modified the test assertions to directly access user.created_on instead of user.date_joined.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Trivia time!

What is the purpose of the SCIM protocol?

Click here for the answer

SCIM (System for Cross-domain Identity Management) is designed to simplify user identity management in the cloud, providing a defined schema for representing users and groups, and a RESTful API to manipulate those resources.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request fixes broken SCIM tests by updating the factories and test assertions to align with recent changes in the codebase. The changes look good and address the immediate issue. However, I've added a minor suggestion to improve the code.

Summary of Findings

Assessment

The pull request effectively fixes the broken SCIM tests. The changes are straightforward and address the issue described in the pull request description. I recommend merging this pull request after considering the minor suggestion provided. As always, ensure that another team member reviews and approves these changes before merging.

[mbertrand]

👍 , though for me the tests take a really long time to run locally.