Skip to content

Add initial users app #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Add initial users app #2013

merged 1 commit into from
Feb 6, 2025

Conversation

rhysyngsun
Copy link
Contributor

@rhysyngsun rhysyngsun commented Feb 5, 2025

What are the relevant tickets?

Part of https://github.com/mitodl/hq/issues/6679

Note: this is based on the PR #2012.

Description (What does it do?)

This adds an initial users app with an empty migration, per the steps outlined in the issue above.

There are also a few changes regarding SSL certificates and database backups I wanted to commit to avoid an extra PR just for those.

How can this be tested?

The app should still function, the main point of this PR is to get an entry for 0001_initial.py into the django_migrations table.

NOTE: you don't need to reverse the migration after using this branch, in fact you'll have to apply it later anyway so you might as well leave it

@rhysyngsun rhysyngsun mentioned this pull request Feb 5, 2025
@rhysyngsun rhysyngsun marked this pull request as ready for review February 6, 2025 20:40
@rhysyngsun rhysyngsun added the Needs Review An open Pull Request that is ready for review label Feb 6, 2025
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr looks good. i did have some lingering questions about what we end up doing with the profiles app if it makes sense to consolidate the custom user object into that.

@rhysyngsun rhysyngsun merged commit eaa4b60 into main Feb 6, 2025
11 checks passed
@rhysyngsun rhysyngsun deleted the nl/initial_user_app branch February 6, 2025 21:02
@odlbot odlbot mentioned this pull request Feb 10, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review An open Pull Request that is ready for review Waiting on author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants