Skip to content

Fix certification parameter, update prompts, catch json parsing error… #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

mbertrand
Copy link
Member

@mbertrand mbertrand commented Dec 20, 2024

What are the relevant tickets?

N/A

Description (What does it do?)

  • Fixes the certification search parameter
  • Updates example prompts
  • Catches any debug info json parsing errors

Screenshots (if appropriate):

Screenshot 2024-12-20 at 11 29 45 AM

How can this be tested?

  • Set OPENAI_API_KEY and POSTHOG_* env settings to the same as RC
  • Go to http://open.odl.local:8062/chat/
  • Try out the example prompts, they should return reasonable responses
  • Try asking your own questions, asking for courses with certificates. You should get results assuming there are any courses on your subject of interest that offer certificates.

@@ -9,9 +9,23 @@ import { useFeatureFlagEnabled } from "posthog-js/react"

const CONVERSATION_OPTTIONS = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticiced the typo OPTTIONS -> OPTIONS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

prompt:
"I would like to learn about linear regression, preferably at no cost.",
},
{ prompt: "What is the relationship between albedo and climate?" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prompt is too unpredictable for now.

Copy link
Contributor

@abeglova abeglova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mbertrand mbertrand merged commit 90bdbba into main Dec 20, 2024
11 checks passed
This was referenced Dec 20, 2024
This was referenced Jan 2, 2025
@rhysyngsun rhysyngsun deleted the mb/chat_cert_fix branch February 7, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants