-
Notifications
You must be signed in to change notification settings - Fork 3
add bordered button variant #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
":hover:not(:disabled)": { | ||
backgroundColor: colors.lightGray1, | ||
}, | ||
":disabled": { | ||
backgroundColor: colors.lightGray2, | ||
border: `1px solid ${colors.silverGrayDark}`, | ||
color: colors.silverGrayDark, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The color darkens on hover, and the border when disabled should be same color as background. (You're right that Figma says the border color is silverGrayDark, but figma also says the border width is 0. I think setting the width to zero will mess up the height. I don't trust figma css :p)
":hover:not(:disabled)": { | |
backgroundColor: colors.lightGray1, | |
}, | |
":disabled": { | |
backgroundColor: colors.lightGray2, | |
border: `1px solid ${colors.silverGrayDark}`, | |
color: colors.silverGrayDark, | |
}, | |
":hover:not(:disabled)": { | |
backgroundColor: colors.lightGray1, | |
color: colors.darkGray2, | |
}, | |
":disabled": { | |
backgroundColor: colors.lightGray2, | |
borderColor: colors.lightGray2 | |
color: colors.silverGrayDark, | |
}, |
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/6277
Description (What does it do?)
This PR adds the
bordered
variant to theButton
component and updates the Storybook stories to demonstrate its usage.Screenshots (if appropriate):
How can this be tested?
mit-learn
on this branchbordered
button variant behaves as expected in normal, hover and disabled states according to the designs linked in the issue