Skip to content

specify non-free course for differing prices test #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

gumaerc
Copy link
Contributor

@gumaerc gumaerc commented Dec 6, 2024

What are the relevant tickets?

Follow-up for #1876

Description (What does it do?)

This PR fixes a flaky test introduced in the above PR

How can this be tested?

  • In frontends/ol-utilities/src/learning-resources/learning-resources.test.ts, on line 125, modify it to be test.each(new Array(1000).fill(null))("returns false if prices differ", () => { to repeat the test 1000 times
  • Spin up mit-learn
  • Run docker compose exec watch yarn test learning-resources
  • Verify that the tests pass every time

Copy link
Contributor

@jonkafton jonkafton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense for the expectedPrices counts and not seeing flakiness after running 15 or so times locally.

@gumaerc gumaerc merged commit 95ecb59 into main Dec 6, 2024
11 checks passed
@odlbot odlbot mentioned this pull request Dec 9, 2024
15 tasks
@rhysyngsun rhysyngsun deleted the cg/all-runs-identical-flaky-test branch February 7, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants