Skip to content

Add parent id to podcast api #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 5, 2024
Merged

Conversation

shanbady
Copy link
Contributor

@shanbady shanbady commented Nov 25, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5886

Description (What does it do?)

This pr adds the parent podcast id to podcast episode api responses

How can this be tested?

  1. checkout this branch.
  2. make sure you have podcasts loaded up locally python manage.py backpopulate_podcast_data
  3. pick a podcast episode's id and visit the api endpoint http://open.odl.local:8063/api/v1/podcast_episodes/{episode id}/
  4. note that there is a "podcasts" attribute that contains the parent podcast id
  5. use that id to visit the podcast api http://open.odl.local:8063/api/v1/podcasts/{podcast id}/

@shanbady shanbady marked this pull request as ready for review November 25, 2024 16:40
@shanbady shanbady marked this pull request as draft November 25, 2024 16:47
@shanbady shanbady marked this pull request as ready for review November 25, 2024 17:11
@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Nov 25, 2024
@mbertrand mbertrand self-assigned this Nov 26, 2024
@mbertrand mbertrand added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Nov 26, 2024
@shanbady shanbady requested a review from mbertrand December 2, 2024 18:49
@mbertrand mbertrand added Needs Review An open Pull Request that is ready for review and removed Waiting on author labels Dec 5, 2024
Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbertrand mbertrand added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Dec 5, 2024
@shanbady shanbady merged commit 72a0de8 into main Dec 5, 2024
11 checks passed
@shanbady shanbady deleted the shanbady/add-parent-id-to-podcast-api branch December 5, 2024 18:28
@odlbot odlbot mentioned this pull request Dec 9, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants