Skip to content

set min cpu and memory. also add qdrant container #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

shanbady
Copy link
Contributor

What are the relevant tickets?

Closes #1843

Description (What does it do?)

updates the default configuration so that codespaces will launch a 4cpu and 16gb memory instance by default. This Pr also updates runServices in devcontainer.json to include the qdrant service.

How can this be tested?

  1. Click this button to open the default options for the main branch
    Open in GitHub Codespaces
  2. observe that "2-code" is pre-selected as the machine type
  3. Open the launch page for this branch
    Open Main branch in GitHub Codespaces
  4. see that the "4-core" option is now the default
  5. use the link above and actually launch the codespace for this branch.
  6. once it finishes building and you can access the terminal, confirm the qdrant container is running by curling the qdrant dashboard page curl http://qdrant:6333/dashboard

@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Nov 21, 2024
@shanbady shanbady marked this pull request as ready for review November 21, 2024 20:22
@mbertrand mbertrand self-assigned this Nov 22, 2024
Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! One non-critical suggestion, take or leave: expose port 6333 for the codespace in case we want to query/browse the qdrant store directly via its dashboard.

Also, on a side note, not directly related to this PR, I found out that in order for secrets to actually be assigned to codespace containers and not just the terminal, they have to be added to devcontainer.json file in a containerEnv section like this:

  "containerEnv": {
    "OPENAI_API_KEY": "${localEnv:OPENAI_API_KEY}"
  },

@mbertrand mbertrand added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Nov 22, 2024
@shanbady
Copy link
Contributor Author

containerEnv

Good idea. I exposed the qdrant port.

re: secrets in the container - interesting I'm going to have to look a bit more into that because right now there are certain secrets that have defaults set via docker-compose.codespaces.yml which pulls in from envs/codespaces.env (which I think do get properly set during build time) in addition to secrets added via github settings. Its possible that some of those are not properly getting forwarded into the container

@shanbady shanbady merged commit d49cd8a into main Nov 22, 2024
11 checks passed
@shanbady shanbady deleted the shanbady/codespace-set-host-config branch November 22, 2024 21:26
@odlbot odlbot mentioned this pull request Nov 25, 2024
19 tasks
mbertrand pushed a commit that referenced this pull request Dec 2, 2024
* set min cpu and memory. also add qdrant container

* exposing qdrant port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codespace config: Update minimum host requirements and add qdrant service
2 participants