Refactor user lists and learning paths hooks out of learning resources #1842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkafton
force-pushed
the
jk/refactor-learning-resources-api
branch
from
1478d59 to
1b6a124
Compare
mbertrand
added
Needs Review
ChristopherChudzicki
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
mentioning: Most of this file should go away as part of https://github.com/mitodl/hq/issues/6032
thank goodness.
| // }) | ||
| // } | ||
|
|
||
| // const useUserListRelationshipCreate = () => { |
There was a problem hiding this comment.
Mentioning: This hook, and associated learning path ones, were used prior to #1463. Prior to 1463, items ("relationships") were created when user checked or unchecked the checkbox. Now they are all added at once when user clicks "Save".
mbertrand
pushed a commit
that referenced
this pull request
Nov 22, 2024
#1842) * Refactor learning path API hooks out of learning resources * Refactor user list API hooks out of learning resources. Dead code commented out * Move post mutation helpers to hooks files * Remove empty file * Remove commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
N/A
Description (What does it do?)
Refactors the learning resource API hooks to pull out Learning Paths and User lists. This align the cache key structure with the API path structure / data models, keying
["learningPaths", ...]and["userLists", ...]at the top level. Much of the data on the site relates to learning resources, so the learning resources API handling was getting large with relationships as children of learning resources.This identified a lot of the user list code as unused. It is commented out in this PR so we can first determine whether it is worth keeping for any upcoming usage.
How can this be tested?
Non-functional change. Test should pass and everything should work as previously, with particular attention to user list and learning path memberships and their action buttons on resource cards and list items; ensuring that these behave as expected as we add and remove from lists and navigate between screens (homepage carousels, search results, dashboard user list details and admin learning paths).
Additional Context
Refactored to lay things out more clearly for https://github.com/mitodl/hq/issues/6032, which introduces memberships that specify the relationships between learning resources and lists (the membership lists are on the learning path and user lists APIs).