Skip to content

v2 learning resource drawer formats and location #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,43 @@ const courses = {
],
}),
},
multipleFormats: makeResource({
resource_type: ResourceTypeEnum.Course,
location: "Earth",
delivery: [
{
code: DeliveryEnum.Online,
name: DeliveryEnumDescriptions.online,
},
{
code: DeliveryEnum.InPerson,
name: DeliveryEnumDescriptions.in_person,
},
],
runs: [
factories.learningResources.run({
delivery: sameDataRun.delivery,
resource_prices: sameDataRun.resource_prices,
location: sameDataRun.location,
}),
],
}),
singleFormat: makeResource({
resource_type: ResourceTypeEnum.Course,
delivery: [
{
code: DeliveryEnum.Online,
name: DeliveryEnumDescriptions.online,
},
],
runs: [
factories.learningResources.run({
delivery: sameDataRun.delivery,
resource_prices: sameDataRun.resource_prices,
location: sameDataRun.location,
}),
],
}),
}

const resourceArgType = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -165,14 +165,16 @@ describe("Learning resource info section start date", () => {
})
})

test("If data is different, dates and prices are not shown", () => {
test("If data is different then dates, formats, locations and prices are not shown", () => {
const course = courses.multipleRuns.differentData
render(<InfoSectionV2 resource={course} />, {
wrapper: ThemeProvider,
})
const section = screen.getByTestId("drawer-info-items")
expect(within(section).queryByText("Start Date:")).toBeNull()
expect(within(section).queryByText("Price:")).toBeNull()
expect(within(section).queryByText("Format:")).toBeNull()
expect(within(section).queryByText("Location:")).toBeNull()
})

test("Clicking the show more button should show more dates", async () => {
Expand All @@ -189,3 +191,34 @@ describe("Learning resource info section start date", () => {
expect(runDates.children.length).toBe(totalRuns + 1)
})
})

describe("Learning resource info section format and location", () => {
test("Multiple formats", () => {
const course = courses.multipleFormats
render(<InfoSectionV2 resource={course} />, {
wrapper: ThemeProvider,
})

const section = screen.getByTestId("drawer-info-items")
within(section).getAllByText((_content, node) => {
// The pipe in this string is followed by a zero width space
return node?.textContent === "Format:Online|​In person" || false
})
within(section).getAllByText((_content, node) => {
return node?.textContent === "Location:Earth" || false
})
})

test("Single format", () => {
const course = courses.singleFormat
render(<InfoSectionV2 resource={course} />, {
wrapper: ThemeProvider,
})

const section = screen.getByTestId("drawer-info-items")
within(section).getAllByText((_content, node) => {
return node?.textContent === "Format:Online" || false
})
expect(within(section).queryByText("In person")).toBeNull()
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@ import {
RiPresentationLine,
RiAwardFill,
RiAwardLine,
RiComputerLine,
RiMapPinLine,
} from "@remixicon/react"
import { LearningResource, ResourceTypeEnum } from "api"
import { DeliveryEnum, LearningResource, ResourceTypeEnum } from "api"
import {
allRunsAreIdentical,
formatDurationClockTime,
Expand Down Expand Up @@ -232,6 +234,15 @@ const RunDates: React.FC<{ resource: LearningResource }> = ({ resource }) => {
}
}

const shouldShowFormat = (resource: LearningResource) => {
return (
(resource.resource_type === ResourceTypeEnum.Course ||
resource.resource_type === ResourceTypeEnum.Program) &&
allRunsAreIdentical(resource) &&
resource.delivery
)
}

const INFO_ITEMS: InfoItemConfig = [
{
label: (resource: LearningResource) => {
Expand All @@ -248,6 +259,41 @@ const INFO_ITEMS: InfoItemConfig = [
} else return null
},
},
{
label: "Format:",
Icon: RiComputerLine,
selector: (resource: LearningResource) => {
if (shouldShowFormat(resource)) {
const totalFormats = resource.delivery?.length || 0
return resource.delivery.map((format, index) => {
return (
<InfoItemValue
key={`format-${index}`}
label={format.name}
index={index}
total={totalFormats}
/>
)
})
} else return null
},
},
{
label: "Location:",
Icon: RiMapPinLine,
selector: (resource: LearningResource) => {
if (
shouldShowFormat(resource) &&
resource.delivery?.filter(
(d) =>
d.code === DeliveryEnum.InPerson || d.code === DeliveryEnum.Hybrid,
).length > 0 &&
resource.location
) {
return <InfoItemValue label={resource.location} index={1} total={1} />
} else return null
},
},
{
label: "Price:",
Icon: RiPriceTag3Line,
Expand Down