move facets first in tab order #1751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
force-pushed
the
cc/search-tab-order
branch
from
295062e to
d166568
Compare
ChristopherChudzicki
added
the
Needs Review
This was referenced Oct 31, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5419
Description (What does it do?)
Puts facets after search results in tab order (and DOM order)
How can this be tested?
/searchor on the channel pages. Starting from the search text field, you should see:Note: This change makes the facets a bit harder to get to, but the search results themselves are easier to get to.
Facets are still—somewhat—easily navigated to with a screenreader via the "Search FIlters" heading.