Fix Laravel Doctrine Service Provider #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use aliases instead
Our service is not deferred. Provides method used by provider repository to register events loaded for deferred service.
npmarrin
added a commit
to npmarrin/laravel-doctrine
that referenced
this pull request
Jan 26, 2015
npmarrin
added a commit
to npmarrin/laravel-doctrine
that referenced
this pull request
Jan 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aliases the Doctrine\ORM\EntityManagerInterface to our service, instead bind as singleton it to Container. Remove provides methods because our service provider is not deferred service. That method is not necessary for non deferred service.