Should check for SoftDeletes traits in parent classes also. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhjcz
force-pushed
the
feature/softdel-parents-traits-fix
branch
from
04e448c to
f4e82ed
Compare
hhjcz
force-pushed
the
feature/softdel-parents-traits-fix
branch
from
f4e82ed to
9a5e4e8
Compare
hhjcz
force-pushed
the
feature/softdel-parents-traits-fix
branch
from
9a5e4e8 to
fd3917f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SoftDeletes trait is used in superclass, the isSoftDeletable doesn't detect it. This fix works for me.