Add mDNS configuration #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altonen
requested review from
muursh,
erubboli,
iljakuklic and
TheQuantumPhysicist
as code owners
stanislav-tkach
approved these changes
Jul 18, 2022
TheQuantumPhysicist
approved these changes
Jul 19, 2022
|
Enums serialized quite nicely, let me know what you think |
Looking good! I'm glad we tried. |
Remove the old `DiscoveryStrategy` enum from the networking interface and instead let the user configure whether mDNS is enabled via command line.
muursh
reviewed
Jul 25, 2022
muursh
reviewed
Jul 25, 2022
muursh
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.