Various changes related to the fork detection script #1972
Merged
+1,122
−277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of miscellaneous changes:
Also, tracing spans are now propagated when subsystem calls are made. This way when p2p calls the chainstate and something happens, we'll know the peer id that caused it.
preliminary_block_checkandpreliminary_headers_checknow check if the block already exists. This fixes a bug where if a peer was too slow, we could receive an already existing block from it when the block height was already below the reorg limit, which would lead to it being punished for nothing.HasSubObjWithSameId. Useful to be able to produceWithId<&SignedBlockHeader>from&WithId<Block>without recalculating the id.