mempool: Better index representation #1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `Map<T, Set<TxId>>` to `Set<(T, TxId)>`. This representation makes it easier to maintain certain invariants, eliminating some bookkeeping, and generally simplifies code. It is also slightly more efficient, reducing mempool memory requirements by about 5-10%.
iljakuklic
requested review from
ImplOfAnImpl,
OBorce,
TheQuantumPhysicist,
alfiedotwtf and
azarovh
iljakuklic
commented
Aug 10, 2023
| type TrackedMap<K, V> = Tracked<BTreeMap<K, V>>; | ||
| type TrackedSet<K> = Tracked<BTreeSet<K>>; | ||
| type TrackedTxIdMultiMap<K> = TrackedMap<K, TrackedSet<Id<Transaction>>>; | ||
| type TrackedTxIdMultiMap<K> = TrackedSet<(K, Id<Transaction>)>; |
There was a problem hiding this comment.
This is the change. Everything else is to make the code work with this representation, usually simplifying the code in the process.
TheQuantumPhysicist
approved these changes
Aug 10, 2023
muursh
approved these changes
Aug 10, 2023
alfiedotwtf
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Map<T, Set<TxId>>toSet<(T, TxId)>. This representation makes it easier to maintain certain invariants, eliminating some bookkeeping, and generally simplifies code.It is also slightly more efficient, reducing mempool memory requirements by about 5-10%.