Skip to content

Check also in Cargo toml files for TODO(PR) and FIXME #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Check also in Cargo toml files for TODO(PR) and FIXME #1160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/scripts/codecheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import re
import sys
import toml
import itertools

SCALECODEC_RE = r'\bparity_scale_codec(_derive)?::'
JSONRPSEE_RE = r'\bjsonrpsee[_a-z0-9]*::'
Expand Down Expand Up @@ -39,6 +40,16 @@ def rs_sources(exclude = []):
if os.path.splitext(file)[1].lower() == '.rs':
yield os.path.join(top, file)

# List Cargo config files
def cargo_config_files(exclude = []):
exclude = [ os.path.normpath(dir) for dir in ['target', '.git', '.github'] + exclude ]
is_excluded = lambda top, d: os.path.normpath(os.path.join(top, d).lower()) in exclude

for top, dirs, files in os.walk('.', topdown=True):
dirs[:] = [ d for d in dirs if not is_excluded(top, d) ]
for file in files:
if os.path.splitext(file)[1].lower() == '.toml':
yield os.path.join(top, file)

# Cargo.toml files
def cargo_toml_files(exclude = []):
Expand Down Expand Up @@ -242,7 +253,7 @@ def check_todos():
]

ok = True
for path in rs_sources():
for path in itertools.chain(rs_sources(), cargo_config_files()):
if any(os.path.samefile(path, exempted) for exempted in exempted_files):
continue

Expand Down