Enable retrieving both transactions and blocks in json format #1155
Conversation
TheQuantumPhysicist
requested review from
azarovh,
erubboli,
iljakuklic and
muursh
as code owners
There was a problem hiding this comment.
Just gave it a quick first pass.
Besides the minor comments below, one more thought regarding the serialization of binary data. Binary data should really be encoded using encode_bytes rather than encode_str. However, I suspect serde-json encodes bytes as an json array of numbers. That could be addressed by creating a wrapper serializer that forwards encode_bytes to encode_str by converting it into hex and passes through everything else into the inner serializer. One shortcoming is that convenience methods like serde_json::to_string will no longer be available since they hard-code the serializer from the crate. Thoughts?
| impl serde::Serialize for InputWitness { | ||
| fn serialize<S: serde::Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> { | ||
| serializer.serialize_str(&self.hex_encode()) |
There was a problem hiding this comment.
Serialize for Destination adds the 0x prefix but here InputWitness does not. Is there a reason for the distinction? Is it to distinguish Destination encoded as hex vs bech32?
On a vaguely related note, maybe instead of calling serialize_str directly, we could exploit the fact that HexEncoded already implements Serialize:
HexEncoded::new(self).serialize(serializer)The serialization of binary data in hex will have a unified code path.
There was a problem hiding this comment.
Yep. It's to make that distinction.
Done that serialization thing.
No description provided.