Change magic bytes functional test #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovh
requested review from
TheQuantumPhysicist,
erubboli,
iljakuklic and
muursh
as code owners
azarovh
changed the title
iljakuklic
approved these changes
Aug 8, 2023
muursh
approved these changes
Aug 8, 2023
TheQuantumPhysicist
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functional test to check that if magic bytes changes the whole chainstate db got cleaned up.
Ideally the same test should be written for changing chainstate version and chain type. But I couldn't figure out the way to achieve that so I thinks that's good enough so far.