-
Notifications
You must be signed in to change notification settings - Fork 42
Add Open DHC + Pedestal goal #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,7 @@ POIN fastBombArrow; WORD 0x2002B4D 1 | |
| POIN kinstoneBag; WORD 0x2002B4B 1 | ||
| POIN fusionFlags; WORD 0x2002C81 13 | ||
| POIN startingFlags; WORD 0x2002C9C 116 | ||
| POIN dhcGuards; WORD 0x2002DB4 1 | ||
| POIN dungeonPortal; WORD 0x2002EBD 6 | ||
| #ifndef requirementFigurinesAmount | ||
| POIN figurines; WORD 0x2002B0E 18 | ||
|
|
@@ -570,6 +571,9 @@ BYTE 0x40 //remove the messages when picking shells for the first time | |
| fusionFlags: | ||
| BYTE mC81 mC82 mC83 mC84 mC85 mC86 mC87 mC88 mC89 mC8A mC8B mC8C mC8D | ||
|
|
||
| dhcGuards: | ||
| BYTE 0x02 // move the dhc guards out of the way of the south entrance | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Always moved the guards since they don't particularly impact anything except the vaatiWarp and openPed goals There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tiny nitpick: With Normal DHC, you can normally see the guards afer pulling the pedestal, and they only disappear after reaching the entrance room (which is the vanilla behavior). It's only visual in Rando, but I think it would be nice to retain that, which could be achieved my putting line 27 inside an |
||
|
|
||
| kinstoneBag: | ||
| BYTE 0x40 | ||
|
|
||
|
|
@@ -1191,6 +1195,7 @@ BYTE 0x10 | |
| cuccoGame: | ||
| BYTE ( (cuccoSkippedLevels << 3) | (cuccoHeartPieceFlag << 7) ) | ||
|
|
||
|
|
||
| startingFlags: | ||
| // 0x00 0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09 0x0A 0x0B 0x0C 0x0D 0x0E 0x0F | ||
| /*0x2002C9C*/ BYTE 0x00 0x00 0x38 0xC0 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a clear location for vaati to differentiate between the vaati in sanctuary (vaatiWarp) or regular dhc vaati.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be careful with the line breaks at the end of lines 88 and 99 here, they would cause an empty line to be drawn. The texts are good!