Skip to content

Conversation

@jiuker
Copy link
Contributor

@jiuker jiuker commented Jul 28, 2025

make sidecar readniess configurable

Description

fix #2464

Related Issue

Type of Change

  • Bug fix 🐛
  • New feature 🚀
  • Breaking change 🚨
  • Documentation update 📖
  • Refactor 🔨
  • Other (please describe) ⬇️

Screenshots (if applicable e.g before/after)

Checklist

  • I have tested these changes
  • I have updated relevant documentation (if applicable)
  • I have added necessary unit tests (if applicable)

Test Steps

Additional Notes / Context

make sidecar readniess configurable
@jiuker jiuker requested review from cniackz, harshavardhana, pjuarezd and ramondeklein and removed request for ramondeklein July 28, 2025 04:04
@pjuarezd
Copy link
Member

pjuarezd commented Oct 9, 2025

Why not just increase the InitialDelaySeconds, I don't see why make the entire readiness probe configurable for a DNS delay

@jiuker
Copy link
Contributor Author

jiuker commented Oct 13, 2025

For operators, I think it's better for users to be able to set up and optimize a relatively complete function, @harshavardhana cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Make the Readiness been modifiable

2 participants