Skip to content

fix sanitize file path while drag and drop #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix sanitize file path while drag and drop #3492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web-app/src/screens/Console/Buckets/ListBuckets/Objects/ListObjects/ListObjects.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ import TooltipWrapper from "../../../../Common/TooltipWrapper/TooltipWrapper";
import ListObjectsTable from "./ListObjectsTable";
import FilterObjectsSB from "../../../../ObjectBrowser/FilterObjectsSB";
import AddAccessRule from "../../../BucketDetails/AddAccessRule";
import { sanitizeFilePath } from "./utils";

const DeleteMultipleObjects = withSuspense(
React.lazy(() => import("./DeleteMultipleObjects")),
Expand Down Expand Up @@ -506,7 +507,7 @@ const ListObjects = () => {

const blobFile = new Blob([file], { type: file.type });

const filePath = get(file, "path", "");
const filePath = sanitizeFilePath(get(file, "path", ""));
const fileWebkitRelativePath = get(file, "webkitRelativePath", "");

let relativeFolderPath = folderPath;
Expand Down
5 changes: 5 additions & 0 deletions web-app/src/screens/Console/Buckets/ListBuckets/Objects/ListObjects/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,8 @@ export const displayFileIconName = (

return <IconWithLabel icon={icon} strings={splitItem} />;
};

export const sanitizeFilePath = (filePath: string) => {
// Replace `./` at the start of the path or preceded by `/` - happens when drag drop upload of files (not folders !) in chrome
return filePath.replace(/(^|\/)\.\//g, "/");
};
Loading