Skip to content

Conversation

cesnietor
Copy link
Collaborator

@cesnietor cesnietor commented Jan 17, 2024

It also catches correctly the error and shows it as snackbar.
It updates swagger yaml to be able to handle array of strings as input.

Test Steps

  1. Go to User/Access Keys
  2. Create a Key
  3. Delete a single Key using the garbage icon
  4. Key should be deleted and keys reloaded.

/// multiple Keys

  1. Go to User/Access Keys
  2. Create multiple Keys
  3. Select multiple Keys
  4. Click Delete Selected
  5. Keys should be deleted and keys reloaded.

@cesnietor cesnietor force-pushed the use-swagger-api-delete-sa branch from 43c83a4 to 440eee7 Compare January 17, 2024 23:39
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. LGTM 👍

@cesnietor cesnietor enabled auto-merge (squash) January 18, 2024 16:53
Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @cesnietor plus all tests are passing!.

@cesnietor cesnietor merged commit b9f0ccf into minio:master Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants