Skip to content

Conversation

dvaldivia
Copy link
Collaborator

To keep the naming of the web app across projects consistent we are renaming portal-ui to web-app

Signed-off-by: Daniel Valdivia <[email protected]>
Signed-off-by: Daniel Valdivia <[email protected]>
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't we just call it ui/ ?

@dvaldivia
Copy link
Collaborator Author

@harshavardhana we could but we call it web-app everywhere else xD

@dvaldivia dvaldivia merged commit 239b317 into minio:master Dec 29, 2023
@dvaldivia dvaldivia deleted the rename-portal-ui-web-app branch December 29, 2023 17:44
@djwfyi djwfyi mentioned this pull request Jan 11, 2024
2 tasks
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
Signed-off-by: Daniel Valdivia <[email protected]>
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
Signed-off-by: Daniel Valdivia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants