Skip to content

fix event dest icons not loading when subpath is configured #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2023
Merged

fix event dest icons not loading when subpath is configured #3169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73e3c96
fix event dest icons not loading when subpath is configured
prakashsvmx Dec 26, 2023
9c7d6af
Merge branch 'master' into evt-tgt-icons-subpath
dvaldivia Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions portal-ui/src/screens/Console/EventDestinations/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export const notifyNats = "notify_nats";
export const notifyElasticsearch = "notify_elasticsearch";
export const notifyWebhooks = "notify_webhook";
export const notifyNsq = "notify_nsq";

export const notificationTransform = (
notificationElements: NotificationEndpointItem[],
) => {
Expand All @@ -48,65 +47,69 @@ export class DestType {
static Func: string = "functions";
}

const getImgBaseURL = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use ${document.baseURI} directly instead of this function

return `${document.baseURI}`;
};

export const destinationList = [
{
actionTrigger: notifyPostgres,
targetTitle: "PostgreSQL",
logo: "/postgres-logo.svg",
logo: `${getImgBaseURL()}postgres-logo.svg`,
category: DestType.DB,
},
{
actionTrigger: notifyKafka,
targetTitle: "Kafka",
logo: "/kafka-logo.svg",
logo: `${getImgBaseURL()}kafka-logo.svg`,
category: DestType.Queue,
},
{
actionTrigger: notifyAmqp,
targetTitle: "AMQP",
logo: "/amqp-logo.svg",
logo: `${getImgBaseURL()}amqp-logo.svg`,
category: DestType.Queue,
},
{
actionTrigger: notifyMqtt,
targetTitle: "MQTT",
logo: "/mqtt-logo.svg",
logo: `${getImgBaseURL()}mqtt-logo.svg`,
category: DestType.Queue,
},
{
actionTrigger: notifyRedis,
targetTitle: "Redis",
logo: "/redis-logo.svg",
logo: `${getImgBaseURL()}redis-logo.svg`,
category: DestType.Queue,
},
{
actionTrigger: notifyNats,
targetTitle: "NATS",
logo: "/nats-logo.svg",
logo: `${getImgBaseURL()}nats-logo.svg`,
category: DestType.Queue,
},
{
actionTrigger: notifyMysql,
targetTitle: "Mysql",
logo: "/mysql-logo.svg",
logo: `${getImgBaseURL()}mysql-logo.svg`,
category: DestType.DB,
},
{
actionTrigger: notifyElasticsearch,
targetTitle: "Elastic Search",
logo: "/elasticsearch-logo.svg",
logo: `${getImgBaseURL()}elasticsearch-logo.svg`,
category: DestType.DB,
},
{
actionTrigger: notifyWebhooks,
targetTitle: "Webhook",
logo: "/webhooks-logo.svg",
logo: `${getImgBaseURL()}webhooks-logo.svg`,
category: DestType.Func,
},
{
actionTrigger: notifyNsq,
targetTitle: "NSQ",
logo: "/nsq-logo.svg",
logo: `${getImgBaseURL()}nsq-logo.svg`,
category: DestType.Queue,
},
];
Expand Down