-
Notifications
You must be signed in to change notification settings - Fork 461
Update Share Object UI to reflect max expiration time #3098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
portal-ui/src/screens/Console/Buckets/BucketDetails/bucketDetailsSlice.ts
Show resolved
Hide resolved
6206a3a
to
9f04074
Compare
909c39b
to
87145b9
Compare
portal-ui/src/screens/Console/Buckets/ListBuckets/Objects/ObjectDetails/ShareFile.tsx
Outdated
Show resolved
Hide resolved
@jinapurapu they are encoded in the url anyways so it's ok. |
Two suggested patterns @cesnietor (Forgot to hit Comment yesterday 😓 ) #. Show Max Possible Time The following URL lets you share this object without requiring a login. TOOLTIP #. Show Remaining Session Time The following URL lets you share this object without requiring a login. TOOLTIP |
87145b9
to
c8f6abd
Compare
@ravindk89 I've updated the PR using the first proposal and looks good. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
part of solution for: #922
Updates the UI to show the max expiration time returned from
/api/v1/buckets/max-share-exp
API.It also adds some documentation on how that works.
Before:

After:

Test Steps:
25h40m
In the console UI with an existing bucket with an object:
Share
To TEST full integration:
make build && MINIO_STS_DURATION=15m ./minio server ~/Data
(the min allowed duration is 15 min) less than that it will return an invalid duration error.share
and change the time to your preferred value.To TEST with IDP no env:
To TEST with IDP with env: