Skip to content

feat(ObjectManager): virtualize download/upload object list #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2023
Merged

feat(ObjectManager): virtualize download/upload object list #2889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f40d79f
feat(ObjectManager): virtualize download/upload object list
ali-garajian Jun 16, 2023
f8a5484
Merge branch 'master' into master-fork
ali-garajian Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions portal-ui/src/screens/Console/Common/ObjectManager/ObjectManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
deleteFromList,
} from "../../ObjectBrowser/objectBrowserSlice";
import clsx from "clsx";
import VirtualizedList from "../VirtualizedList/VirtualizedList";

const styles = (theme: Theme) =>
createStyles({
Expand Down Expand Up @@ -66,6 +67,7 @@ const styles = (theme: Theme) =>
overflowX: "hidden",
minHeight: 250,
maxHeight: 335,
height: "100%",
width: "100%",
display: "flex",
flexDirection: "column",
Expand Down Expand Up @@ -98,6 +100,16 @@ const ObjectManager = ({ classes }: IObjectManager) => {
const anonymousMode = useSelector(
(state: AppState) => state.system.anonymousMode
);

function renderObject(index: number) {
return (
<ObjectHandled
objectToDisplay={objects[index]}
deleteFromList={(instanceID) => dispatch(deleteFromList(instanceID))}
/>
);
}

return (
<Fragment>
{managerOpen && (
Expand All @@ -123,15 +135,11 @@ const ObjectManager = ({ classes }: IObjectManager) => {
</div>
<div className={classes.title}>Downloads / Uploads</div>
<div className={classes.actionsContainer}>
{objects.map((object, key) => (
<ObjectHandled
objectToDisplay={object}
key={`object-handled-${object.instanceID}`}
deleteFromList={(instanceID) =>
dispatch(deleteFromList(instanceID))
}
/>
))}
<VirtualizedList
rowRenderFunction={renderObject}
totalItems={objects.length}
defaultHeight={110}
/>
</div>
</Box>
)}
Expand Down