-
Notifications
You must be signed in to change notification settings - Fork 463
Refactor session to avoid duplicate calls to apis #2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d8d10b2
to
69e9709
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Changes look good to me. 👍
Seeing a session call every time I navigate @cesnietor |
@dvaldivia yes it was like that already before. I mentioned it in the description of the ticket as well. |
1952c0d
to
cb77e08
Compare
@prakashsvmx @reivaj05 @dvaldivia @jinapurapu I've updated the PR addressing the comments and also doing the following -> We will no longer call |
cb77e08
to
de57482
Compare
rebased. |
Description:
Refactors the way we were calling
/session
api since previous implementaiton was making multiple requests (up to six) which could mean high latency if that requests take time to resolve. Now we call it only once and only at initial load.Changes:
/browser
to avoid redirecting first to/
and then to/browser
when logging in.Before:

After:

If navigating between tabs it won't call session api.

Test Steps:
Scenarios:
make assets && make
then run it on port 9090 like:/session
api are not more than one./session
only ONCE at initial load of whole page)/
] and try to access to it without loging in). Everything should work just fine.