Skip to content

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented May 26, 2023

What does this do?

Migrated available Access Keys components to mds.

How does it look?

Screenshot 2023-05-25 at 21 48 03 Screenshot 2023-05-25 at 21 47 53 Screenshot 2023-05-25 at 21 47 47 Screenshot 2023-05-25 at 21 47 42 Screenshot 2023-05-25 at 21 47 37

@bexsoft bexsoft self-assigned this May 26, 2023
@bexsoft bexsoft changed the title Migrated Access Keys page compoents to mds Migrated Access Keys page components to mds May 26, 2023
@bexsoft bexsoft force-pushed the migrate-account-page branch from ffe57e9 to 57e3502 Compare May 26, 2023 04:11
@prakashsvmx
Copy link
Member

Few Observations:

If a user with no policies assigned log in, the

  • Create Access Key should be disabled, ( For the admin user, in the user details screen of the user, it is disabled )
  • Change Password shows error "Error please check your current password." - Even though valid password is provided while changing.

Modals do not hide on Esc Key.

There is a bug in the select/delete of table rows.

Steps

  • Create few accesskey rows,
  • select few rows
  • Click delete from any one row and confirm
  • Click Delete All - Observe the count in the confirmation modal.
    image

@bexsoft
Copy link
Collaborator Author

bexsoft commented May 26, 2023

@prakashsvmx Confirmed these issues, this is not related to this change as it happens in current version too.
Will fix them in a second PR

For the Esc to close modal, this will be fixed in mds repo

Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@bexsoft bexsoft merged commit 0285702 into minio:master May 26, 2023
@bexsoft bexsoft deleted the migrate-account-page branch May 26, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants