Skip to content

Added identifier field to Event destinations page & migrated to mds #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 17, 2023
Merged

Added identifier field to Event destinations page & migrated to mds #2816

merged 4 commits into from
May 17, 2023

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented May 13, 2023

fixes #666

What does this do?

  • Added Identifier field to event destination page to allow multiple events of the same type.
  • Migrated all visual components to mds

NOTE: There is an issue where after adding a new Lambda Event Destination, list doesn't refresh, this is expected as you need to restart MinIO server to retrieve this new configuration. Also need to implement form validation in forms

How does it look?

Screenshot 2023-05-12 at 18 51 12 Screenshot 2023-05-12 at 18 51 06 Screenshot 2023-05-12 at 18 50 58

@bexsoft bexsoft self-assigned this May 13, 2023
cesnietor
cesnietor approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allanrogerr
Copy link
Contributor

Lets fix #666 !

@bexsoft bexsoft merged commit fc9319e into minio:master May 17, 2023
@bexsoft bexsoft deleted the lambda-fixes branch February 29, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivaj05 reivaj05 reivaj05 approved these changes

@cesnietor cesnietor cesnietor approved these changes

@allanrogerr allanrogerr allanrogerr approved these changes

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@cniackz cniackz Awaiting requested review from cniackz

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@dilverse dilverse Awaiting requested review from dilverse

Assignees

@bexsoft bexsoft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding of 2 lambda notifications of the same type
4 participants
@bexsoft @allanrogerr @reivaj05 @cesnietor